]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/os: do not move temporay variable
authorKefu Chai <kchai@redhat.com>
Thu, 29 Oct 2020 08:21:06 +0000 (16:21 +0800)
committerKefu Chai <kchai@redhat.com>
Thu, 29 Oct 2020 08:32:26 +0000 (16:32 +0800)
copy ellision ensures that copy ctor is not called in this case

silences warning like:

mson/os/seastore/lba_manager/btree/lba_btree_node_impl.cc:262:5: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
    std::move(begin()),
    ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/crimson/os/seastore/lba_manager/btree/lba_btree_node_impl.cc

index 93f52adf635d3bc46ea3247b31a7c2a016738b97..47b974b5f40e0d5068bb72c6eb44bfccd59dda3f 100644 (file)
@@ -259,8 +259,7 @@ LBAInternalNode::scan_mapped_space_ret LBAInternalNode::scan_mapped_space(
 {
   f(get_paddr(), get_length());
   return crimson::do_for_each(
-    std::move(begin()),
-    std::move(end()),
+    begin(), end(),
     [=, &f](auto &viter) {
       return get_lba_btree_extent(
        c,