mgr/dashboard: Explicitly type page variables

Explicitly gives a type to page variables.
Helps make better use of Typescript's static type checking.
Undoes mistake from #29070.

Fixes: https://tracker.ceph.com/issues/40961
Signed-off-by: Adam King <adking@redhat.com>
Signed-off-by: Rafael Quintero <rquinter@redhat.com>

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/block/images.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/block/images.e2e-spec.ts
index 8af22236410e22be0b36ebb8b9d2bdc1b1f64af4..44c97415e344df76670fd22dd6bc6e4fef7bc5e6 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/block/images.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/block/images.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('Images page', () => {
-  let images;
+  let images: Helper['images'];
 
   beforeAll(() => {
     images = new Helper().images;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/block/iscsi.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/block/iscsi.e2e-spec.ts
index f088eeac63da8b079e86539b7dea8620ba5f68ad..523ab2e9f56dfda1cae92a3a005c44de86333552 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/block/iscsi.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/block/iscsi.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('Iscsi Page', () => {
-  let iscsi;
+  let iscsi: Helper['iscsi'];
 
   beforeAll(() => {
     iscsi = new Helper().iscsi;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/block/mirroring.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/block/mirroring.e2e-spec.ts
index 60dd992bc53b4e021cbdecb0305d1be71580afba..b0108f0cb5c4a2e725895e2b9ed1054501ebb66f 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/block/mirroring.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/block/mirroring.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('Mirroring page', () => {
-  let mirroring;
+  let mirroring: Helper['mirroring'];
 
   beforeAll(() => {
     mirroring = new Helper().mirroring;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/cluster/alerts.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/cluster/alerts.e2e-spec.ts
index 038453a06be3f1e99e41c21ad1de801a3ea76890..963f32eefe627e3edd2b0fc0ff20942c3e905b37 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/cluster/alerts.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/cluster/alerts.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('Alerts page', () => {
-  let alerts;
+  let alerts: Helper['alerts'];
 
   beforeAll(() => {
     alerts = new Helper().alerts;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/cluster/configuration.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/cluster/configuration.e2e-spec.ts
index 29a348f45348853f81ea5a2ed887e9ff1ffa5ec0..b2c7ae9a802b36f7549afc9c25a021122752871f 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/cluster/configuration.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/cluster/configuration.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('Configuration page', () => {
-  let configuration;
+  let configuration: Helper['configuration'];
 
   beforeAll(() => {
     configuration = new Helper().configuration;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/cluster/crush-map.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/cluster/crush-map.e2e-spec.ts
index 47d5493ea95fee5000b2feba52d9ba5f58d45ce7..d58fa9bc6b31f01101a45b4b93aa2b3c82a73e57 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/cluster/crush-map.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/cluster/crush-map.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('CRUSH map page', () => {
-  let crushmap;
+  let crushmap: Helper['crushmap'];
 
   beforeAll(() => {
     crushmap = new Helper().crushmap;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/cluster/hosts.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/cluster/hosts.e2e-spec.ts
index 094c7771d2935d2bb16a88658339b1264fa8eac4..a04ca3c05dbba11186bb25f29e00fe00f2bd7d47 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/cluster/hosts.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/cluster/hosts.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('Hosts page', () => {
-  let hosts;
+  let hosts: Helper['hosts'];
 
   beforeAll(() => {
     hosts = new Helper().hosts;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/cluster/logs.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/cluster/logs.e2e-spec.ts
index 8202744c5146ecf4ee520e25cf372dd7183a9e19..0cf6433a2ca011a7500cb9d1fc4bf8a8aba83f92 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/cluster/logs.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/cluster/logs.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('Logs page', () => {
-  let logs;
+  let logs: Helper['logs'];
 
   beforeAll(() => {
     logs = new Helper().logs;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/cluster/mgr-modules.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/cluster/mgr-modules.e2e-spec.ts
index 5f786b08eceb279bbaf6b15d6a54392eef579f04..2dc916b0ba43fec0d62d973178a34ebded6b2f19 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/cluster/mgr-modules.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/cluster/mgr-modules.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('Manager modules page', () => {
-  let mgrmodules;
+  let mgrmodules: Helper['mgrmodules'];
 
   beforeAll(() => {
     mgrmodules = new Helper().mgrmodules;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/cluster/monitors.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/cluster/monitors.e2e-spec.ts
index 596b4492180806c7b61814d1944fb9c926eb67eb..9c7f9635f5d4fa9057be12357e609545e598bc57 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/cluster/monitors.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/cluster/monitors.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('Monitors page', () => {
-  let monitors;
+  let monitors: Helper['monitors'];
 
   beforeAll(() => {
     monitors = new Helper().monitors;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/cluster/osds.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/cluster/osds.e2e-spec.ts
index bb8216e434f2e85db6152e0bae2052d96aea47fe..391e8f111148cc1c92474e9df9c3688a7951e563 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/cluster/osds.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/cluster/osds.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('OSDs page', () => {
-  let osds;
+  let osds: Helper['osds'];
 
   beforeAll(() => {
     osds = new Helper().osds;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/filesystems/filesystems.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/filesystems/filesystems.e2e-spec.ts
index 1146dad3571628d0d33b314a14150968793bbb1b..9a90c8585806f8bb1c6443596f693e120b5d9fc4 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/filesystems/filesystems.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/filesystems/filesystems.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('Filesystems page', () => {
-  let filesystems;
+  let filesystems: Helper['filesystems'];
 
   beforeAll(() => {
     filesystems = new Helper().filesystems;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/nfs/nfs.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/nfs/nfs.e2e-spec.ts
index 803c8ea5abca1780d8d936e023a434ca7edacc25..ea6ac7df74dfda0483ee8486460f26c23f91284e 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/nfs/nfs.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/nfs/nfs.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('Nfs page', () => {
-  let nfs;
+  let nfs: Helper['nfs'];
 
   beforeAll(() => {
     nfs = new Helper().nfs;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/pools/pools.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/pools/pools.e2e-spec.ts
index e30a872912553cb69f1f82bea6d8b89cb9dfb18a..26166fa2775e4ce34926f8b6e30ce3decce5b43b 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/pools/pools.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/pools/pools.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('Pools page', () => {
-  let pools;
+  let pools: Helper['pools'];
   const poolName = 'pool_e2e_pool_test';
 
   beforeAll(() => {

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/rgw/buckets.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/rgw/buckets.e2e-spec.ts
index d3d87b9cf6c939343ea1f9dba0136b08567c09e6..c1415899128606a6ab546df9c55b63eda29af1ed 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/rgw/buckets.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/rgw/buckets.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('RGW buckets page', () => {
-  let buckets;
+  let buckets: Helper['buckets'];
 
   beforeAll(() => {
     buckets = new Helper().buckets;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/rgw/daemons.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/rgw/daemons.e2e-spec.ts
index 484379309246ef07944f22d242412a4817e86813..b8e00e41c92655d2f0b2de83a5c98bf88642ec3c 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/rgw/daemons.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/rgw/daemons.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('RGW daemons page', () => {
-  let daemons;
+  let daemons: Helper['daemons'];
 
   beforeAll(() => {
     daemons = new Helper().daemons;

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/rgw/users.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/rgw/users.e2e-spec.ts
index d096a8fc940f93c17dcb87996c3b41d58620363f..1791e4974f8e7474c69c3ae56489ef63cb25a81c 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/rgw/users.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/rgw/users.e2e-spec.ts
@@ -1,7 +1,7 @@
 import { Helper } from '../helper.po';
 
 describe('RGW users page', () => {
-  let users;
+  let users: Helper['users'];
   const user_name = '000user_create_edit_delete';
 
   beforeAll(() => {