]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
client: when STATX_NLINK is requested request FsLs caps 38355/head
authorJeff Layton <jlayton@redhat.com>
Fri, 20 Nov 2020 23:43:31 +0000 (18:43 -0500)
committerJeff Layton <jlayton@redhat.com>
Fri, 20 Nov 2020 23:46:52 +0000 (18:46 -0500)
We currently determine the getattr request mask prior to doing the
lookup, so we don't necessarily know whether the terminal entry is
a directory or something else.

Directory nlink count is governed by the dirstats, and those are
under Fs caps. Request both Fs and Ls if the request mask includes
STATX_NLINK.

Fixes: https://tracker.ceph.com/issues/48313
Signed-off-by: Jeff Layton <jlayton@redhat.com>
src/client/Client.cc

index fc4e3487ef752efa97e5d70a86892e29901ed11e..b13fc7b755244d39278351c083f42320ebafcdf8 100644 (file)
@@ -7612,7 +7612,7 @@ unsigned Client::statx_to_mask(unsigned int flags, unsigned int want)
     mask |= CEPH_CAP_AUTH_SHARED;
   if (want & (CEPH_STATX_NLINK|CEPH_STATX_CTIME|CEPH_STATX_VERSION))
     mask |= CEPH_CAP_LINK_SHARED;
-  if (want & (CEPH_STATX_ATIME|CEPH_STATX_MTIME|CEPH_STATX_CTIME|CEPH_STATX_SIZE|CEPH_STATX_BLOCKS|CEPH_STATX_VERSION))
+  if (want & (CEPH_STATX_NLINK|CEPH_STATX_ATIME|CEPH_STATX_MTIME|CEPH_STATX_CTIME|CEPH_STATX_SIZE|CEPH_STATX_BLOCKS|CEPH_STATX_VERSION))
     mask |= CEPH_CAP_FILE_SHARED;
   if (want & (CEPH_STATX_VERSION|CEPH_STATX_CTIME))
     mask |= CEPH_CAP_XATTR_SHARED;