]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
filestore: Initialize Zipkin traces when there is a store trace
authorVictor Araujo <ve.ar91@gmail.com>
Mon, 5 Sep 2016 12:15:03 +0000 (14:15 +0200)
committerSage Weil <sage@redhat.com>
Fri, 5 May 2017 18:05:23 +0000 (14:05 -0400)
Avoids creating orphaned traces.

Signed-off-by: Victor Araujo <ve.ar91@gmail.com>
src/os/filestore/FileJournal.cc

index bf13c44cadda686ef902dc34989e0f202a6d9257..7e6a19cbf0e1f66c4037d2ff33bca696e8121df7 100644 (file)
@@ -1623,9 +1623,11 @@ void FileJournal::submit_entry(uint64_t seq, bufferlist& e, uint32_t orig_len,
 
   if (osd_op) {
     osd_op->mark_event("commit_queued_for_journal_write");
-    osd_op->journal_trace.init("journal", &trace_endpoint, &osd_op->store_trace);
-    osd_op->journal_trace.event("submit_entry");
-    osd_op->journal_trace.keyval("seq", seq);
+    if (osd_op->store_trace) {
+      osd_op->journal_trace.init("journal", &trace_endpoint, &osd_op->store_trace);
+      osd_op->journal_trace.event("submit_entry");
+      osd_op->journal_trace.keyval("seq", seq);
+    }
   }
   {
     Mutex::Locker l1(writeq_lock);