]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
librbd: remove unwanted std::move 38313/head
authorWillem Jan Withagen <wjw@digiware.nl>
Fri, 27 Nov 2020 00:17:05 +0000 (01:17 +0100)
committerWillem Jan Withagen <wjw@digiware.nl>
Fri, 27 Nov 2020 00:17:32 +0000 (01:17 +0100)
Clang argues:
```
/home/jenkins/workspace/ceph-master-compile/src/librbd/migration/HttpClient.cc:463:16: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
    response = std::move(m_parser->release());
               ^
/home/jenkins/workspace/ceph-master-compile/src/librbd/migration/HttpClient.cc:463:16: note: remove std::move call here
    response = std::move(m_parser->release());
               ^~~~~~~~~~                   ~
1 warning generated.

```

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
src/librbd/migration/HttpClient.cc

index fff959cca0012d72e2259d0cc5f2f2c7ce44bfed..0cc51ddd861bedd42b65ae63d5fafa45b6248bca 100644 (file)
@@ -460,7 +460,7 @@ private:
     if (work->header_only()) {
       m_parser.emplace(std::move(*m_header_parser));
     }
-    response = std::move(m_parser->release());
+    response = m_parser->release();
 
     // basic response code handling in a common location
     int r = 0;