common/options: rocksdb_cf_compact_on_deletion is false by default

This is a pacific-specific commit; not a backport. All it does is
switching the default value of `rocksdb_cf_compact_on_deletion`.
The rationale is purely our preference towards avoiding huge
baheavioral changes in minor release, particularly of an old
release family.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit c7fd52f207a72c3ac1bb1b83354fd5bd6a44bd13)

diff --git a/src/common/options.cc b/src/common/options.cc
index 457d0ef81216347e72dd063bcdaf57241b7ff65a..4dc69cb0db3abff1b06124e50a57fad4becf8e64 100644 (file)
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -3973,7 +3973,7 @@ std::vector<Option> get_global_options() {
     .set_description("The block size for index partitions. (0 = rocksdb default)"),
 
     Option("rocksdb_cf_compact_on_deletion", Option::TYPE_BOOL, Option::LEVEL_DEV)
-    .set_default(true)
+    .set_default(false)
     .set_description("Compact the column family when a certain number of tombstones are observed within a given window.")
     .set_long_description("This setting instructs RocksDB to compact a column family when a certain number of tombstones are observed during iteration within a certain sliding window. For instance if rocksdb_cf_compact_on_deletion_sliding_window is 8192 and rocksdb_cf_compact_on_deletion_trigger is 4096,  then once 4096 tombstones are observed after iteration over 8192 entries, the column family will be compacted.")
     .add_see_also({"rocksdb_cf_compact_on_deletion_sliding_window", "rocksdb_cf_compact_on_deletion_trigger"}),