mgr/dashboard: fix namespace block size in namespace form

Fixes: https://tracker.ceph.com/issues/76034
Signed-off-by: Sagar Gopale <sagar.gopale@ibm.com>

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.spec.ts
index dd4c35eaa6cf452305e125bedf19b46bd656246c..b2868bc43e4a7783386fbc4a2ab5068c9640e9cf 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.spec.ts
@@ -137,16 +137,16 @@ describe('NvmeofNamespacesFormComponent', () => {
       expect(nvmeofService.createNamespace).toHaveBeenCalled();
     });
 
-    it('should not send block_size from namespace_size UI field', () => {
+    it('should send block_size from namespace_size UI field', () => {
       formHelper.setValue('pool', 'rbd');
       formHelper.setValue('image_size', new FormatterService().toBytes('1GiB'));
       formHelper.setValue('subsystem', MOCK_SUBSYSTEM);
-      formHelper.setValue('namespace_size', 10);
+      formHelper.setValue('namespace_size', 1024);
 
       component.onSubmit();
 
       const request = (nvmeofService.createNamespace as jasmine.Spy).calls.mostRecent().args[1];
-      expect(request.block_size).toBeUndefined();
+      expect(request.block_size).toBe(1024);
     });
   });
 });

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.ts
index f3488cb68adce383cd696e7b240669f1a63b457c..a33a06d73b85b617b140e4af0d04433b6df5712e 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.ts
@@ -330,6 +330,8 @@ export class NvmeofNamespacesFormComponent implements OnInit {
 
     const loopCount = isGatewayProvisioned ? nsCount : 1;
 
+    const blockSize = this.nsForm.getValue('namespace_size');
+
     for (let i = 1; i <= loopCount; i++) {
       const request: NamespaceCreateRequest = {
         gw_group: this.group,
@@ -338,6 +340,10 @@ export class NvmeofNamespacesFormComponent implements OnInit {
         no_auto_visible: noAutoVisible
       };
 
+      if (blockSize) {
+        request.block_size = blockSize;
+      }
+
       if (isGatewayProvisioned) {
         const rbdImageName = this.nsForm.getValue('rbd_image_name');
         if (rbdImageName) {