]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw/rgw_user.cc: fix possible NULL pointer dereference 285/head
authorDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Tue, 14 May 2013 17:20:29 +0000 (19:20 +0200)
committerDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Tue, 14 May 2013 17:20:29 +0000 (19:20 +0200)
CID 1019559 (#1 of 1): Dereference after null check (FORWARD_NULL)
  var_deref_model: Passing null pointer "usr" to function
  "RGWUser::get_store()", which dereferences it.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
src/rgw/rgw_user.cc

index b160ff87444c89df3bb50c659fed8099218fcafb..781fce46eda81728398598d1003630aec2dd0ec5 100644 (file)
@@ -992,7 +992,10 @@ int RGWAccessKeyPool::remove(RGWUserAdminOpState& op_state, std::string *err_msg
 RGWSubUserPool::RGWSubUserPool(RGWUser *usr)
 {
   subusers_allowed = (usr != NULL);
-  store = usr->get_store();
+  if (usr)
+    store = usr->get_store();
+  else
+    store = NULL;
   user = usr;
   subuser_map = NULL;
 }