secret: return error on empty secret

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>

diff --git a/src/common/secret.c b/src/common/secret.c
index 365782ff04fe59b7001a41ad2d004d573581acba..11ca8bf4e5d7f812024d2ea8153a57b267c004b5 100644 (file)
--- a/src/common/secret.c
+++ b/src/common/secret.c
@@ -58,6 +58,11 @@ static int set_kernel_secret(const char *secret, const char *key_name)
   char payload[((secret_len * 3) / 4) + 4];
   char error_buf[80];
 
+  if (!secret_len) {
+    fprintf(stderr, "secret is empty.\n");
+    return -EINVAL;
+  }
+
   ret = ceph_unarmor(payload, payload+sizeof(payload), secret, secret+secret_len);
   if (ret < 0) {
     fprintf(stderr, "secret is not valid base64: %s.\n",