mds: add FIXME for renames between snaprealms

The lock gather may be sufficient to propagate the updated snaprealm to
the replica; it might not. See #925.

See: #926
Signed-off-by: Sage Weil <sage@newdream.net>

diff --git a/src/mds/Server.cc b/src/mds/Server.cc
index fcd59c556b888093311740652bf10b82a3709c70..3374894ed1b44733f9fa283152d9657aae7d5699 100644 (file)
--- a/src/mds/Server.cc
+++ b/src/mds/Server.cc
@@ -4620,7 +4620,9 @@ void Server::handle_client_rename(MDRequest *mdr)
     if (oldin->is_dir())
       rdlocks.insert(&oldin->filelock);
   }
-  if (srcdnl->is_primary() && srci->is_dir())
+  if (srcdnl->is_primary() && srci->is_dir())  
+    // FIXME: this should happen whenever we are renamning between
+    // realms, regardless of the file type
     xlocks.insert(&srci->snaplock);  // FIXME: an auth bcast could be sufficient?
   else
     rdlocks.insert(&srci->snaplock);