]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/dashboard_v2: add mgr to the list of perf counters 20783/head
authorTiago Melo <tmelo@suse.com>
Wed, 7 Mar 2018 15:39:27 +0000 (15:39 +0000)
committerTiago Melo <tmelo@suse.com>
Tue, 13 Mar 2018 15:21:43 +0000 (15:21 +0000)
Signed-off-by: Tiago Melo <tmelo@suse.com>
qa/tasks/mgr/dashboard_v2/test_perf_counters.py
src/pybind/mgr/dashboard_v2/controllers/perf_counters.py

index 6be867bd30eb87307f6d8a2a6baf9ed79274b5e2..6f38260303dcdf1c10776cf9a0af4742a3f370b3 100644 (file)
@@ -20,13 +20,14 @@ class PerfCountersControllerTest(DashboardTestCase):
             self.assertIn('osd.{}'.format(osd['osd']), data)
 
     @authenticate
-    def test_perf_counters_mon_a_get(self):
-        data = self._get('/api/perf_counters/mon/a')
+    def test_perf_counters_mon_get(self):
+        mon = self.mons()[0]
+        data = self._get('/api/perf_counters/mon/{}'.format(mon))
         self.assertStatus(200)
 
         self.assertIsInstance(data, dict)
         self.assertEqual('mon', data['service']['type'])
-        self.assertEqual('a', data['service']['id'])
+        self.assertEqual(mon, data['service']['id'])
         self.assertIsInstance(data['counters'], list)
         self.assertGreater(len(data['counters']), 0)
         counter = data['counters'][0]
@@ -35,3 +36,15 @@ class PerfCountersControllerTest(DashboardTestCase):
         self.assertIn('name', counter)
         self.assertIn('unit', counter)
         self.assertIn('value', counter)
+
+    @authenticate
+    def test_perf_counters_mgr_get(self):
+        mgr = self.mgr_cluster.mgr_ids[0]
+        data = self._get('/api/perf_counters/mgr/{}'.format(mgr))
+        self.assertStatus(200)
+
+        self.assertIsInstance(data, dict)
+        self.assertEqual('mgr', data['service']['type'])
+        self.assertEqual(mgr, data['service']['id'])
+        self.assertIsInstance(data['counters'], list)
+        self.assertEqual(len(data['counters']), 0)
index 63d62fedddf98de9324f93f331d9f1ae3bc9afb4..59692d3309a16b014f2dd3c6b45b680ddd8c1479 100644 (file)
@@ -59,6 +59,7 @@ class PerfCounters(RESTController):
         self.osd = PerfCounter('osd')
         self.rgw = PerfCounter('rgw')
         self.rbd_mirror = PerfCounter('rbd-mirror')
+        self.mgr = PerfCounter('mgr')
 
     def list(self):
         counters = mgr.get_all_perf_counters()