mon, osd: Clean up "flush(stringstream); bl.append(stringstream.str())

Also: One redundant flush in AuthMonitor, two in PGMonitor, and
a ds << that should have been conditional in Monitor.

Signed-off-by: Dan Mick <dan.mick@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>

diff --git a/src/auth/KeyRing.cc b/src/auth/KeyRing.cc
index 56655392bae66c6edd90c4389927908bfa029662..5a8b2288e6aa434f24d17296f2adadb863741076 100644 (file)
--- a/src/auth/KeyRing.cc
+++ b/src/auth/KeyRing.cc
@@ -157,8 +157,7 @@ void KeyRing::encode_formatted(string label, Formatter *f, bufferlist& bl)
     f->close_section();        /* auth_entities */
   }
   f->close_section();  /* auth_dump */
-  f->flush(os);
-  bl.append(os.str());
+  f->flush(bl);
 }
 
 void KeyRing::decode_plaintext(bufferlist::iterator& bli)

diff --git a/src/client/Client.cc b/src/client/Client.cc
index af465cb78bc2921d19ddf0c755c1801729f89b12..4b10cf5c1bac45fb7fc6f9fc7ec246280e7ec75a 100644 (file)
--- a/src/client/Client.cc
+++ b/src/client/Client.cc
@@ -117,8 +117,7 @@ bool Client::CommandHook::call(std::string command, cmdmap_t& cmdmap,
   else
     assert(0 == "bad command registered");
   m_client->client_lock.Unlock();
-  f->flush(ss);
-  out.append(ss);
+  f->flush(out);
   delete f;
   return true;
 }

diff --git a/src/mon/AuthMonitor.cc b/src/mon/AuthMonitor.cc
index 629451b5eac7f3fa4649bf041ff36cea8ff7321e..f165b8c9fc7472b811138cb416d15439eb42ce93 100644 (file)
--- a/src/mon/AuthMonitor.cc
+++ b/src/mon/AuthMonitor.cc
@@ -626,7 +626,6 @@ bool AuthMonitor::preprocess_command(MMonCommand *m)
   } else if (prefix == "auth list") {
     if (f) {
       mon->key_server.encode_formatted("auth", f.get(), rdata);
-      f->flush(rdata);
     } else {
       mon->key_server.encode_plaintext(rdata);
       if (rdata.length() > 0)

diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc
index 118cf6f4a1ee59cbe265665e3a9cb82d50a66e37..b55aff0a19031d9694b8e5ac7b9c8cdb082da920 100644 (file)
--- a/src/mon/Monitor.cc
+++ b/src/mon/Monitor.cc
@@ -1952,9 +1952,8 @@ void Monitor::handle_command(MMonCommand *m)
     f->close_section();        // command_descriptions
 
     bufferlist rdata;
-    f->flush(ds);
+    f->flush(rdata);
     delete f;
-    rdata.append(ds);
     reply_command(m, 0, "", rdata, 0);
     return;
   }
@@ -2016,13 +2015,13 @@ void Monitor::handle_command(MMonCommand *m)
   }
 
   if (prefix == "fsid") {
-    ds << monmap->fsid;
     if (f) {
       f->open_object_section("fsid");
       f->dump_stream("fsid") << monmap->fsid;
       f->close_section();
       f->flush(rdata);
     } else {
+      ds << monmap->fsid;
       rdata.append(ds);
     }
     reply_command(m, 0, "", rdata, 0);

diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc
index c6db052a591feabd5b27b6d8093783b9a606de4e..f86b17f5e104931f805a7e0f38f328f793bbdba3 100644 (file)
--- a/src/mon/OSDMonitor.cc
+++ b/src/mon/OSDMonitor.cc
@@ -1966,8 +1966,9 @@ bool OSDMonitor::preprocess_command(MMonCommand *m)
   if (prefix == "osd stat") {
     osdmap.print_summary(f.get(), ds);
     if (f)
-      f->flush(ds);
-    rdata.append(ds);
+      f->flush(rdata);
+    else
+      rdata.append(ds);
   }
   else if (prefix == "osd dump" ||
           prefix == "osd tree" ||
@@ -2080,9 +2081,7 @@ bool OSDMonitor::preprocess_command(MMonCommand *m)
       f->dump_string(p->first.c_str(), p->second);
     f->close_section();
     f->close_section();
-    f->flush(ds);
-    ds << "\n";
-    rdata.append(ds);
+    f->flush(rdata);
   } else if (prefix == "osd map") {
     string poolstr, objstr, namespacestr;
     cmd_getval(g_ceph_context, cmdmap, "pool", poolstr);

diff --git a/src/mon/PGMonitor.cc b/src/mon/PGMonitor.cc
index ab4a5b3044734382f52b9c61e4fee17c4e0ad381..29c77dbe0ed2c9b1e96c70cf85a23600971ca19e 100644 (file)
--- a/src/mon/PGMonitor.cc
+++ b/src/mon/PGMonitor.cc
@@ -1358,7 +1358,6 @@ bool PGMonitor::preprocess_command(MMonCommand *m)
     } else {
       ds << pg_map;
     }
-    rdata.append(ds);
     r = 0;
   } else if (prefix == "pg getmap") {
     pg_map.encode(rdata);

diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc
index 69c181862ccf8d9decdf80517ff53733130bf88d..e4653dc1f70c7133188608309ab3f9f0649fdbab 100644 (file)
--- a/src/osd/OSD.cc
+++ b/src/osd/OSD.cc
@@ -3935,7 +3935,6 @@ void OSD::do_command(Connection *con, tid_t tid, vector<string>& cmd, bufferlist
     f->close_section();        // command_descriptions
 
     f->flush(ds);
-    odata.append(ds);
     delete f;
     goto out;
   }

diff --git a/src/osdc/Objecter.cc b/src/osdc/Objecter.cc
index 2b1e7f9e41b056e3b164239bb32a0b49b622b48b..88336cacce3884ad198a9e6eaf5cd5624f3aedd1 100644 (file)
--- a/src/osdc/Objecter.cc
+++ b/src/osdc/Objecter.cc
@@ -2348,9 +2348,8 @@ bool Objecter::RequestStateHook::call(std::string command, cmdmap_t& cmdmap,
   m_objecter->client_lock.Lock();
   m_objecter->dump_requests(f);
   m_objecter->client_lock.Unlock();
-  f->flush(ss);
+  f->flush(out);
   delete f;
-  out.append(ss);
   return true;
 }