]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr: zabbix triggers never triggered due to wrong trigger function 26146/head
authorSebastiaan Nijhuis <sebastiaan.nijhuis@maastrichtuniversity.nl>
Fri, 25 Jan 2019 12:06:33 +0000 (13:06 +0100)
committerSebastiaan Nijhuis <sebastiaan.nijhuis@maastrichtuniversity.nl>
Fri, 25 Jan 2019 12:06:33 +0000 (13:06 +0100)
Triggers "Number of IN OSDs decreased" and "Number of UP OSDs decresed" never triggered due to change()>0 in trigger expression. If the numder of OSD's IN or UP changed, the change would be negative. Changed change() to abschange() to fix this.

Signed-off-by: Sebastiaan Nijhuis <sebastiaan.nijhuis@maastrichtuniversity.nl>
src/pybind/mgr/zabbix/zabbix_template.xml

index 1ce76605ac07ffaf2fce7eeac9995c76664d5e81..f1a1495d43333b103267a2b08c89f3617c39a93d 100644 (file)
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <zabbix_export>
     <version>3.0</version>
-    <date>2017-10-24T07:00:13Z</date>
+    <date>2019-01-25T10:12:41Z</date>
     <groups>
         <group>
             <name>Templates</name>
             <dependencies/>
         </trigger>
         <trigger>
-            <expression>{ceph-mgr Zabbix module:ceph.num_osd_in.change()}&gt;0</expression>
-            <name>Number of IN OSDs decreased</name>
+            <expression>{ceph-mgr Zabbix module:ceph.num_osd_in.abschange()}&gt;0</expression>
+            <name>Number of IN OSDs changed</name>
             <url/>
             <status>0</status>
             <priority>2</priority>
-            <description>Amount of OSDs in IN state decreased</description>
+            <description>Amount of OSDs in IN state changed</description>
             <type>0</type>
             <dependencies/>
         </trigger>
         <trigger>
-            <expression>{ceph-mgr Zabbix module:ceph.num_osd_up.change()}&gt;0</expression>
-            <name>Number of UP OSDs decreased</name>
+            <expression>{ceph-mgr Zabbix module:ceph.num_osd_up.abschange()}&gt;0</expression>
+            <name>Number of UP OSDs changed</name>
             <url/>
             <status>0</status>
             <priority>2</priority>
-            <description>Amount of OSDs in UP state decreased</description>
+            <description>Amount of OSDs in UP state changed</description>
             <type>0</type>
             <dependencies/>
         </trigger>