msg/Pipe: make banner buffer slightly bigger

CID 717023: Out-of-bounds access (OVERRUN_DYNAMIC)
At (4): Allocating insufficient memory for the terminating null of the string.

This appears to be a false positive (we don't interpret the buffer as a
string, ever), but it will make coverity happier.

Signed-off-by: Sage Weil <sage@inktank.com>

diff --git a/src/msg/Pipe.cc b/src/msg/Pipe.cc
index e26c818d3a743d1f78dc3d5baeea772b21380319..3e409f1042bf1121660a7b73dff0b81a952c7d10 100644 (file)
--- a/src/msg/Pipe.cc
+++ b/src/msg/Pipe.cc
@@ -594,7 +594,7 @@ int Pipe::connect()
   struct msghdr msg;
   struct iovec msgvec[2];
   int msglen;
-  char banner[strlen(CEPH_BANNER)];
+  char banner[strlen(CEPH_BANNER) + 1];  // extra byte makes coverity happy
   entity_addr_t paddr;
   entity_addr_t peer_addr_for_me, socket_addr;
   AuthAuthorizer *authorizer = NULL;