]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/rook: Remove service_type param from remove_service() 38704/head
authorVarsha Rao <varao@redhat.com>
Wed, 23 Dec 2020 13:26:02 +0000 (13:26 +0000)
committerVarsha Rao <varao@redhat.com>
Wed, 23 Dec 2020 13:39:02 +0000 (13:39 +0000)
Orchestrator defines service name as "<service_type>.<service_id>". The
remove_service method requires only service_name as parameter. Removing
service_type parameter fixes the type error.

Fixes: https://tracker.ceph.com/issues/47968
Signed-off-by: Varsha Rao <varao@redhat.com>
src/pybind/mgr/rook/module.py

index eda8571196cdd94c42316998bc05305e516bd533..cef24e5c27c57f802cce9f732d0daec2960d16bb 100644 (file)
@@ -451,12 +451,13 @@ class RookOrchestrator(MgrModule, orchestrator.Orchestrator):
 
     def _service_rm_decorate(self, typename, name, func):
         return write_completion(
-            on_complete=lambda : func(name),
+            on_complete=lambda : func(),
             message="Removing {} services for {}".format(typename, name),
             mgr=self
         )
 
-    def remove_service(self, service_type, service_name):
+    def remove_service(self, service_name):
+        service_type, service_name = service_name.split('.', 1)
         if service_type == 'mds':
             return self._service_rm_decorate(
                 'MDS', service_name, lambda: self.rook_cluster.rm_service(