rbd: add helgrind to valgrind subsuite

This checks locking problems. This can be a separate facet for
workunits, but for now it requires a manual 2nd configuration for
rbd_fsx.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>

diff --git a/suites/rbd/valgrind/validator/helgrind.yaml b/suites/rbd/valgrind/validator/helgrind.yaml
new file mode 100644 (file)
index 0000000..327492a
--- /dev/null
+++ b/suites/rbd/valgrind/validator/helgrind.yaml
@@ -0,0 +1,4 @@
+overrides:
+  workunit:
+    env:
+      VALGRIND: "helgrind"

diff --git a/suites/rbd/valgrind/validator/memcheck.yaml b/suites/rbd/valgrind/validator/memcheck.yaml
new file mode 100644 (file)
index 0000000..abb2991
--- /dev/null
+++ b/suites/rbd/valgrind/validator/memcheck.yaml
@@ -0,0 +1,4 @@
+overrides:
+  workunit:
+    env:
+      VALGRIND: "memcheck"

diff --git a/suites/rbd/valgrind/workloads/c_api_tests.yaml b/suites/rbd/valgrind/workloads/c_api_tests.yaml
index 7f4309fe2a0177613125466a7efd236026e8806d..188ddc56c6078ae51c4cb94ac960271201424af7 100644 (file)
--- a/suites/rbd/valgrind/workloads/c_api_tests.yaml
+++ b/suites/rbd/valgrind/workloads/c_api_tests.yaml
@@ -5,4 +5,3 @@ tasks:
         - rbd/test_librbd.sh
     env:
       RBD_FEATURES: "1"
-      VALGRIND: "memcheck"

diff --git a/suites/rbd/valgrind/workloads/c_api_tests_with_journal.yaml b/suites/rbd/valgrind/workloads/c_api_tests_with_journal.yaml
index 255637aed3974b9b576b43e8b4fb3f09fadac98c..0f760f21b5574c151ca6c5b5d8246c2a90aba08a 100644 (file)
--- a/suites/rbd/valgrind/workloads/c_api_tests_with_journal.yaml
+++ b/suites/rbd/valgrind/workloads/c_api_tests_with_journal.yaml
@@ -5,4 +5,3 @@ tasks:
         - rbd/test_librbd.sh
     env:
       RBD_FEATURES: "127"
-      VALGRIND: "memcheck"

diff --git a/suites/rbd/valgrind/workloads/c_api_tests_with_object_map.yaml b/suites/rbd/valgrind/workloads/c_api_tests_with_object_map.yaml
index 8eb0bd40a6674106f8d653a2c6599de3e4e1d17e..fef368b9bc43850bfbc9e787e89f645e3f8b14fa 100644 (file)
--- a/suites/rbd/valgrind/workloads/c_api_tests_with_object_map.yaml
+++ b/suites/rbd/valgrind/workloads/c_api_tests_with_object_map.yaml
@@ -5,4 +5,3 @@ tasks:
         - rbd/test_librbd.sh
     env:
       RBD_FEATURES: "13"
-      VALGRIND: "memcheck"

diff --git a/suites/rbd/valgrind/workloads/fsx_helgrind.yaml b/suites/rbd/valgrind/workloads/fsx_helgrind.yaml
new file mode 100644 (file)
index 0000000..08cdc2a
--- /dev/null
+++ b/suites/rbd/valgrind/workloads/fsx_helgrind.yaml
@@ -0,0 +1,5 @@
+tasks:
+- rbd_fsx:
+    clients: [client.0]
+    size: 134217728
+    valgrind: [--tool=helgrind]

diff --git a/suites/rbd/valgrind/workloads/python_api_tests.yaml b/suites/rbd/valgrind/workloads/python_api_tests.yaml
index ae05c2d2b9546f55ec5dde140a3a204d441f2492..a7b3ce7d3e61cc65fdbd71e7e2f81abf15401b3f 100644 (file)
--- a/suites/rbd/valgrind/workloads/python_api_tests.yaml
+++ b/suites/rbd/valgrind/workloads/python_api_tests.yaml
@@ -5,4 +5,3 @@ tasks:
         - rbd/test_librbd_python.sh
     env:
       RBD_FEATURES: "1"
-      VALGRIND: "memcheck"

diff --git a/suites/rbd/valgrind/workloads/python_api_tests_with_journal.yaml b/suites/rbd/valgrind/workloads/python_api_tests_with_journal.yaml
index d57abb18edf16778eb02c2bf65645882a6fc9b03..07b3d9f23a64624b193a45defbcfe23bb26ecb6c 100644 (file)
--- a/suites/rbd/valgrind/workloads/python_api_tests_with_journal.yaml
+++ b/suites/rbd/valgrind/workloads/python_api_tests_with_journal.yaml
@@ -5,4 +5,3 @@ tasks:
         - rbd/test_librbd_python.sh
     env:
       RBD_FEATURES: "127"
-      VALGRIND: "memcheck"

diff --git a/suites/rbd/valgrind/workloads/python_api_tests_with_object_map.yaml b/suites/rbd/valgrind/workloads/python_api_tests_with_object_map.yaml
index 0a989eeb2b66aba6ed45d91ef17a5658fc996e3c..ede74cd8d595e68fc25bb8a929a0200906337f97 100644 (file)
--- a/suites/rbd/valgrind/workloads/python_api_tests_with_object_map.yaml
+++ b/suites/rbd/valgrind/workloads/python_api_tests_with_object_map.yaml
@@ -5,4 +5,3 @@ tasks:
         - rbd/test_librbd_python.sh
     env:
       RBD_FEATURES: "13"
-      VALGRIND: "memcheck"