]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
common/ceph_context: fewer warnings about experimental features 14170/head
authorSage Weil <sage@redhat.com>
Tue, 28 Mar 2017 02:18:13 +0000 (22:18 -0400)
committerSage Weil <sage@redhat.com>
Tue, 28 Mar 2017 02:18:13 +0000 (22:18 -0400)
As Pete Zaitcev points out, check_experimental_feature_enabled
warns when an actual experimental feature is used; we don't need
to also warn that we might use it here.

This means we don't notice when a feature is enabled but it isn't
used, but that noise arguably has no value.

Signed-off-by: Sage Weil <sage@redhat.com>
src/common/ceph_context.cc

index a63858e2b3b82f43e2d485cec62a8f76adbb6560..61469968268d5e3523f8547256495e4eb664d0b5 100644 (file)
@@ -305,14 +305,6 @@ public:
        conf->enable_experimental_unrecoverable_data_corrupting_features,
        cct->_experimental_features);
       ceph_spin_unlock(&cct->_feature_lock);
-      if (!cct->_experimental_features.empty()) {
-        if (cct->_experimental_features.count("*")) {
-          lderr(cct) << "WARNING: all dangerous and experimental features are enabled." << dendl;
-        } else {
-          lderr(cct) << "WARNING: the following dangerous and experimental features are enabled: "
-           << cct->_experimental_features << dendl;
-        }
-      }
     }
     if (changed.count("crush_location")) {
       cct->crush_location.update_from_conf();