]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
radosgw-admin: check params for object rewrite
authorYehuda Sadeh <yehuda@inktank.com>
Thu, 19 Sep 2013 17:41:07 +0000 (10:41 -0700)
committerYehuda Sadeh <yehuda@inktank.com>
Fri, 11 Apr 2014 17:08:23 +0000 (10:08 -0700)
Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
(cherry picked from commit 28c716bccd955eaf68e9c739139c901ca4f419f7)

src/erasure-code/jerasure/gf-complete
src/erasure-code/jerasure/jerasure
src/rgw/rgw_admin.cc

index c70286782425b1f792313e4fd1ce1773c72dcd76..191e7105b2b75f7f48ef23dfab9ae72275363168 160000 (submodule)
@@ -1 +1 @@
-Subproject commit c70286782425b1f792313e4fd1ce1773c72dcd76
+Subproject commit 191e7105b2b75f7f48ef23dfab9ae72275363168
index c893bdfb1f7cfdd805aea636e4aabf25ee7f4f33..3135db11ec8f042e502d0765b64bc3a44145a2df 160000 (submodule)
@@ -1 +1 @@
-Subproject commit c893bdfb1f7cfdd805aea636e4aabf25ee7f4f33
+Subproject commit 3135db11ec8f042e502d0765b64bc3a44145a2df
index 202b9ef279101e8b936b6cd972f3e98edecf73e2..8b737270522928d73f060042483c8777394d2b6f 100644 (file)
@@ -1817,6 +1817,14 @@ next:
   }
 
   if (opt_cmd == OPT_OBJECT_REWRITE) {
+    if (bucket_name.empty()) {
+      cerr << "ERROR: bucket not specified" << std::endl;
+      return EINVAL;
+    }
+    if (object.empty()) {
+      cerr << "ERROR: object not specified" << std::endl;
+      return EINVAL;
+    }
     int ret = init_bucket(bucket_name, bucket);
     if (ret < 0) {
       cerr << "ERROR: could not init bucket: " << cpp_strerror(-ret) << std::endl;
@@ -1828,7 +1836,7 @@ next:
 
     if (ret < 0) {
       cerr << "ERROR: object remove returned: " << cpp_strerror(-ret) << std::endl;
-      return 1;
+      return -ret;
     }
   }