Merge pull request #17611 from chardan/jfw-wip-atomic_t-cleanup

follow-up fixups for atomic_t spinlocks

Reviewed-by: Adam Emerson <aemerson@redhat.com>

diff --cc src/msg/xio/XioConnection.cc
index 491d6646e09a093a22913200521c60881fa84582,9fd699752e2b22c5f0c014f02395ea0ffcabe392..7964a15901a72e0fbd8eb816c608b9daeb523da7
--- 1/src/msg/xio/XioConnection.cc
--- 2/src/msg/xio/XioConnection.cc
+++ b/src/msg/xio/XioConnection.cc
@@@ -819,11 -816,11 +816,11 @@@ int XioConnection::CState::state_flow_c
  int XioConnection::CState::state_fail(Message* m, uint32_t flags)
  {
    if (! (flags & OP_FLAG_LOCKED))
-     pthread_spin_lock(&xcon->sp);
+     xcon->sp.lock();
  
    // advance to state FAIL, drop queued, msgs, adjust LRU
 -  session_state = session_states::DISCONNECTED);
 -  startup_state = session_startup_states::FAIL);
 +  session_state = session_states::DISCONNECTED;
 +  startup_state = session_startup_states::FAIL;
  
    xcon->discard_out_queues(flags|OP_FLAG_LOCKED);
    xcon->adjust_clru(flags|OP_FLAG_LOCKED|OP_FLAG_LRU);