]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
messages: fix MMDSBeacon constructor 11281/head
authorJohn Spray <john.spray@redhat.com>
Mon, 3 Oct 2016 06:40:12 +0000 (07:40 +0100)
committerJohn Spray <john.spray@redhat.com>
Tue, 4 Oct 2016 09:57:05 +0000 (11:57 +0200)
This was leaving garbage in some fields during decode
when decoding messages with an older version.

Fixes: http://tracker.ceph.com/issues/17466
Signed-off-by: John Spray <john.spray@redhat.com>
src/messages/MMDSBeacon.h

index d3840a1c49606c5b6ffc8ff7c7d26a7bdfec14b2..a67ba121943df69dc43b551dc49534649cff15bb 100644 (file)
@@ -148,7 +148,12 @@ class MMDSBeacon : public PaxosServiceMessage {
   uint64_t mds_features;
 
  public:
-  MMDSBeacon() : PaxosServiceMessage(MSG_MDS_BEACON, 0, HEAD_VERSION, COMPAT_VERSION) { }
+  MMDSBeacon()
+    : PaxosServiceMessage(MSG_MDS_BEACON, 0, HEAD_VERSION, COMPAT_VERSION),
+    global_id(0), state(MDSMap::STATE_NULL), standby_for_rank(MDS_RANK_NONE),
+    standby_for_fscid(FS_CLUSTER_ID_NONE), standby_replay(false),
+    mds_features(0)
+  { }
   MMDSBeacon(const uuid_d &f, mds_gid_t g, string& n, epoch_t les, MDSMap::DaemonState st, version_t se, uint64_t feat) :
     PaxosServiceMessage(MSG_MDS_BEACON, les, HEAD_VERSION, COMPAT_VERSION),
     fsid(f), global_id(g), name(n), state(st), seq(se),