mgr/dashboard: fix error handling in remote_view_cache

Signed-off-by: John Spray <john.spray@redhat.com>

diff --git a/src/pybind/mgr/dashboard/remote_view_cache.py b/src/pybind/mgr/dashboard/remote_view_cache.py
index 07858ab4ed80ecbe2f124ba8c7f1998818b6e062..294975d762cdd720385baec4ddd3961c6b3d21ea 100644 (file)
--- a/src/pybind/mgr/dashboard/remote_view_cache.py
+++ b/src/pybind/mgr/dashboard/remote_view_cache.py
@@ -22,13 +22,12 @@ class GetterThread(Thread):
             self._view.value = None
             self._view.value_when = None
             self._view.getter_thread = None
-            self.event.set()
-
-        with self._view.lock:
-            self._view.latency = t1 - t0
-            self._view.value = val
-            self._view.value_when = datetime.datetime.now()
-            self._view.getter_thread = None
+        else:
+            with self._view.lock:
+                self._view.latency = t1 - t0
+                self._view.value = val
+                self._view.value_when = datetime.datetime.now()
+                self._view.getter_thread = None
 
         self.event.set()
 
@@ -133,4 +132,4 @@ class RemoteViewCache(object):
         pass
 
     def _get(self):
-        raise NotImplementedError()
\ No newline at end of file
+        raise NotImplementedError()