rgw: prevent bucket reshard scheduling if bucket is resharding

radosgw-admin should prevent a bucket from being added to the reshard
list if it is currently being resharded.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

diff --git a/src/rgw/rgw_admin.cc b/src/rgw/rgw_admin.cc
index 6e7fa46e5a1e47d42f9fb265b15d3641f7bffc69..0d6150e5d33ef7b034ae07240463dd3f0ce2ad7b 100644 (file)
--- a/src/rgw/rgw_admin.cc
+++ b/src/rgw/rgw_admin.cc
@@ -25,6 +25,7 @@ extern "C" {
 
 #include "include/util.h"
 
+#include "cls/rgw/cls_rgw_types.h"
 #include "cls/rgw/cls_rgw_client.h"
 
 #include "global/global_init.h"
@@ -2575,6 +2576,13 @@ int check_reshard_bucket_params(rgw::sal::RGWRadosStore *store,
     return ret;
   }
 
+  if (bucket_info.reshard_status != CLS_RGW_RESHARD_NOT_RESHARDING) {
+    // if in_progress or done then we have an old BucketInfo
+    cerr << "ERROR: the bucket is currently undergoing resharding and "
+      "cannot be added to the reshard list at this time" << std::endl;
+    return -EBUSY;
+  }
+
   int num_source_shards = (bucket_info.num_shards > 0 ? bucket_info.num_shards : 1);
 
   if (num_shards <= num_source_shards && !yes_i_really_mean_it) {