osd: EINVAL when rmw_flags is 0

A broken client (e.g., v0.56) can send a request that ends up with an
rmw_flags of 0.  Treat this as invalid and return EINVAL.

Fixes: #4556
Signed-off-by: Sage Weil <sage@inktank.com>

diff --git a/src/osd/OSD.cc b/src/osd/OSD.cc
index 52123771217157d706edd0b535578baa9311486c..6b9057994961c0e4f13b2ed56702e335c7c826bc 100644 (file)
--- a/src/osd/OSD.cc
+++ b/src/osd/OSD.cc
@@ -6532,5 +6532,8 @@ int OSD::init_op_flags(OpRequestRef op)
     }
   }
 
+  if (op->rmw_flags == 0)
+    return -EINVAL;
+
   return 0;
 }