]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
cmake: require CMake v3.16
authorKefu Chai <kchai@redhat.com>
Mon, 19 Jul 2021 04:55:57 +0000 (12:55 +0800)
committerKefu Chai <kchai@redhat.com>
Mon, 19 Jul 2021 05:16:49 +0000 (13:16 +0800)
since we dropped the support of bionic, we now have the luxury of using
newer CMake! and by using CMake 3.16, we now have access to

* add_compile_definitions(), which was introduced in cmake 3.12

also, drop the comment of

> remove cmake/modules/FindPython* once 3.12 is required

because we need to support python 3.10 in future, better off keeping
the FindPython files around, so we can backport cmake changes from
upstream when necessary.

we are allowed to bump up the CMake's required to 3.16, because:

- ubuntu focal ships with cmake 3.16.3
- RHEL/CentOS8's AppStream has cmake 3.18

Signed-off-by: Kefu Chai <kchai@redhat.com>
CMakeLists.txt

index d6ad17bbf844523210f05d1345b63db9c4c28553..6c6f647bd50e849c497fa2593bd3d7765eefca52 100644 (file)
@@ -1,5 +1,4 @@
-cmake_minimum_required(VERSION 3.10.2)
-# remove cmake/modules/FindPython* once 3.12 is required
+cmake_minimum_required(VERSION 3.16)
 
 project(ceph
   VERSION 17.0.0