]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
qa/tasks/cephfs: use StringIO for capturing str
authorKefu Chai <kchai@redhat.com>
Sat, 28 Mar 2020 11:10:03 +0000 (19:10 +0800)
committerKefu Chai <kchai@redhat.com>
Tue, 2 Jun 2020 02:32:23 +0000 (10:32 +0800)
if we don't expect non-utf8 in stdout, use StringIO instead of BytesIO.

see also d8d44ed1566b19eec055e07da2a0fed88fed4152

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit f10f86579684a0d1b8d99787b8e19709a64df7d6)

Conflicts:
qa/tasks/cephfs/mount.py: trivial resolution

qa/tasks/cephfs/mount.py

index 339e028016201d2692354209b9f1b14c74180d49..7bd6278f81ba8ebde7020ae06d35a03825745745 100644 (file)
@@ -5,6 +5,7 @@ import logging
 import datetime
 import six
 import time
+from six import StringIO
 from textwrap import dedent
 import os
 from teuthology.orchestra import run
@@ -149,7 +150,7 @@ class CephFSMount(object):
         return self.client_remote.run(
                args=['sudo', 'adjust-ulimits', 'daemon-helper', 'kill',
                      py_version, '-c', pyscript], wait=False, stdin=run.PIPE,
-               stdout=BytesIO())
+               stdout=StringIO())
 
     def run_python(self, pyscript, py_version='python'):
         p = self._run_python(pyscript, py_version)
@@ -158,8 +159,8 @@ class CephFSMount(object):
 
     def run_shell(self, args, wait=True, check_status=True, omit_sudo=True):
         args = ["cd", self.mountpoint, run.Raw('&&'), "sudo"] + args
-        return self.client_remote.run(args=args, stdout=BytesIO(),
-                                      stderr=BytesIO(), wait=wait,
+        return self.client_remote.run(args=args, stdout=StringIO(),
+                                      stderr=StringIO(), wait=wait,
                                       check_status=check_status,
                                       omit_sudo=omit_sudo)