]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson: drop store from ECBackend to not shadow PGBackend::store 53288/head
authorRadosław Zarzyński <rzarzyns@redhat.com>
Tue, 5 Sep 2023 13:21:21 +0000 (15:21 +0200)
committerRadosław Zarzyński <rzarzyns@redhat.com>
Tue, 5 Sep 2023 14:19:47 +0000 (16:19 +0200)
This problem was leading to crashes like this one:

```
../src/crimson/os/futurized_store.h:113:41: runtime error: member access within misaligned address 0xbebebebebebebebe for type 'struct Shard', which requires 8 byte alignment
0xbebebebebebebebe: note: pointer points here
<memory cannot be printed>
--Type <RET> for more, q to quit, c to continue without paging--

Thread 1 "crimson-osd" received signal SIGSEGV, Segmentation fault.
0x000055558e7a1dca in crimson::os::FuturizedStore::Shard::do_transaction (txn=..., ch=..., this=0xbebebebebebebebe) at ../src/crimson/os/futurized_store.h:113
113       return do_transaction_no_callbacks(
(gdb) bt
```

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
src/crimson/osd/ec_backend.h

index 3dbcc4def2e01fe5f7b0813aae5e09356a6ef7e9..56fbb44542319e9b38341793836533c255c8891a 100644 (file)
@@ -33,7 +33,6 @@ private:
                      epoch_t min_epoch, epoch_t max_epoch,
                      std::vector<pg_log_entry_t>&& log_entries) final;
   CollectionRef coll;
-  crimson::os::FuturizedStore::Shard* store;
   seastar::future<> request_committed(const osd_reqid_t& reqid,
                                       const eversion_t& version) final {
     return seastar::now();