mgr: Fixed devicehealth plugin resource leak

The devicehealth plugin not close rados connection at show device metrics
 function.

Signed-off-by: Rick Chen <rick.chen@prophetstor.com>

diff --git a/src/pybind/mgr/devicehealth/module.py b/src/pybind/mgr/devicehealth/module.py
index f2dd5368e3a937c06afb0266c17bf3668f99cd6c..aa684225c70f0c20805d3b4daa038436c56dcaed 100644 (file)
--- a/src/pybind/mgr/devicehealth/module.py
+++ b/src/pybind/mgr/devicehealth/module.py
@@ -400,7 +400,9 @@ class Module(MgrModule):
         # fetch metrics
         res = {}
         ioctx = self.open_connection(create_if_missing=False)
-        if ioctx:
+        if not ioctx:
+            return 0, json.dumps(res, indent=4), ''
+        with ioctx:
             with rados.ReadOpCtx() as op:
                 omap_iter, ret = ioctx.get_omap_vals(op, "", sample or '', 500)  # fixme
                 assert ret == 0