]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
AsyncConnection: use move instead of bufferlist copy construct
authorHaomai Wang <haomai@xsky.com>
Thu, 21 Jan 2016 12:08:23 +0000 (20:08 +0800)
committerHaomai Wang <haomai@xsky.com>
Mon, 1 Feb 2016 07:28:21 +0000 (15:28 +0800)
Signed-off-by: Haomai Wang <haomai@xsky.com>
src/msg/async/AsyncConnection.cc
src/msg/async/AsyncConnection.h

index 9c1b250fbcba53fd1c2d787e601710c0cbe47f02..7e9694768e48b5d8c7478cb36ccbaa1455497c67 100644 (file)
@@ -2074,7 +2074,7 @@ int AsyncConnection::send_message(Message *m)
                                << " Drop message " << m << dendl;
     m->put();
   } else {
-    out_q[m->get_priority()].push_back(make_pair(bl, m));
+    out_q[m->get_priority()].emplace_back(std::move(bl), m);
     ldout(async_msgr->cct, 15) << __func__ << " inline write is denied, reschedule m=" << m << dendl;
     center->dispatch_event_external(write_handler);
   }
index 40a9887344f1a9844de89c783dfa9c5f9de8407a..44dc1f436ad7d5d40842c995ff5a3f0a6a67a5c8 100644 (file)
@@ -74,7 +74,7 @@ class AsyncConnection : public Connection {
   void _send_keepalive_or_ack(bool ack=false, utime_t *t=NULL);
   ssize_t write_message(Message *m, bufferlist& bl);
   ssize_t _reply_accept(char tag, ceph_msg_connect &connect, ceph_msg_connect_reply &reply,
-                    bufferlist authorizer_reply) {
+                    bufferlist &authorizer_reply) {
     bufferlist reply_bl;
     reply.tag = tag;
     reply.features = ((uint64_t)connect.features & policy.features_supported) | policy.features_required;