]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
osd/ReplicatedPG: ProxyWriteOp::reqid should not be a ref 5802/head
authorSage Weil <sage@redhat.com>
Fri, 4 Sep 2015 02:01:19 +0000 (22:01 -0400)
committerSage Weil <sage@redhat.com>
Fri, 4 Sep 2015 02:01:19 +0000 (22:01 -0400)
CID 1322778 (#1 of 1): Pointer to local outside scope (RETURN_LOCAL)
1. escape_local_addr: Returning, through this->reqid, the address of stack variable _reqid.
    2. return: Returning here.

Signed-off-by: Sage Weil <sage@redhat.com>
src/osd/ReplicatedPG.h

index 4517e68730ebb1bdefba691c8cd4119708953fa1..31491801ffc0e63671f6b396b81d7bd2a2617272 100644 (file)
@@ -221,7 +221,7 @@ public:
     bool sent_ack;
     utime_t mtime;
     bool canceled;
-    osd_reqid_t &reqid;
+    osd_reqid_t reqid;
 
     ProxyWriteOp(OpRequestRef _op, hobject_t oid, vector<OSDOp>& _ops, osd_reqid_t _reqid)
       : ctx(NULL), op(_op), soid(oid),