]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
RGWPutCORS_ObjStore_S3::get_params: check data before dereference
authorDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Wed, 12 Mar 2014 19:27:57 +0000 (20:27 +0100)
committerDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Wed, 12 Mar 2014 19:27:57 +0000 (20:27 +0100)
CID 1063697 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
 5. var_deref_model: Passing null pointer "data" to function
 "RGWXMLParser::parse(char const *, int, int)", which dereferences it.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
src/rgw/rgw_rest_s3.cc

index 9dfede449c92400bd664e71b0ae85830b4398598..9dd5c50409389315bc811c6c49e927330c0876d8 100644 (file)
@@ -1385,7 +1385,7 @@ int RGWPutCORS_ObjStore_S3::get_params()
     goto done_err;
   }
 
-  if (!parser.parse(data, len, 1)) {
+  if (!data || !parser.parse(data, len, 1)) {
     r = -EINVAL;
     goto done_err;
   }