rgw: reduce string copy

As suggested by Casey Bodley.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
(cherry picked from commit f8f1f217314c32cf65ac1fa4e8e0132b501ee184)

diff --git a/src/rgw/rgw_rest_s3.cc b/src/rgw/rgw_rest_s3.cc
index a2ca9e6cc0ff845ada782ed1098c5fc6924a5560..1b54db7d2463b4d74876b9bdc79c64e9e14fb144 100644 (file)
--- a/src/rgw/rgw_rest_s3.cc
+++ b/src/rgw/rgw_rest_s3.cc
@@ -3301,7 +3301,7 @@ int RGW_Auth_S3::authorize_v4(RGWRados *store, struct req_state *s)
         ldout(store->ctx(), 10) << "NOTICE: failed to parse auth header (s=" << s << ")" << dendl;
         return -EINVAL;
       }
-      kv[key] = val;
+      kv[key] = std::move(val);
     }
 
     for (string& k : aws4_presigned_required_keys) {
@@ -3311,9 +3311,9 @@ int RGW_Auth_S3::authorize_v4(RGWRados *store, struct req_state *s)
       }
     }
 
-    s->aws4_auth->credential = kv["Credential"];
-    s->aws4_auth->signedheaders = kv["SignedHeaders"];
-    s->aws4_auth->signature = kv["Signature"];
+    s->aws4_auth->credential = std::move(kv["Credential"]);
+    s->aws4_auth->signedheaders = std::move(kv["SignedHeaders"]);
+    s->aws4_auth->signature = std::move(kv["Signature"]);
 
     /* sig hex str */
     dout(10) << "v4 signature format = " << s->aws4_auth->signature << dendl;