]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw/swift: remove redundant moves of object name 52719/head
authorCasey Bodley <cbodley@redhat.com>
Mon, 31 Jul 2023 23:52:15 +0000 (19:52 -0400)
committerCasey Bodley <cbodley@redhat.com>
Mon, 31 Jul 2023 23:52:17 +0000 (19:52 -0400)
resolves a compiler warning:

/home/cbodley/ceph/src/rgw/rgw_rest_swift.cc: In member function ‘RGWOp* RGWSwiftWebsiteHandler::get_ws_listing_op()’:
/home/cbodley/ceph/src/rgw/rgw_rest_swift.cc:2558:33: warning: redundant move in initialization [-Wredundant-move]
 2558 |   std::string prefix = std::move(s->object->get_name());
      |                        ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
/home/cbodley/ceph/src/rgw/rgw_rest_swift.cc:2558:33: note: remove ‘std::move’ call

Signed-off-by: Casey Bodley <cbodley@redhat.com>
src/rgw/rgw_rest_swift.cc

index 11e7c647c7d916ad7f298032b1853da037445472..353520b52d80ffc6ac94d0928ec99d3486af8dca 100644 (file)
@@ -1982,7 +1982,7 @@ void RGWFormPost::init(rgw::sal::Driver* const driver,
                        RGWHandler* const dialect_handler)
 {
   if (!rgw::sal::Object::empty(s->object)) {
-    prefix = std::move(s->object->get_name());
+    prefix = s->object->get_name();
     s->object->set_key(rgw_obj_key());
   }
 
@@ -2555,7 +2555,7 @@ RGWOp* RGWSwiftWebsiteHandler::get_ws_listing_op()
     }
   };
 
-  std::string prefix = std::move(s->object->get_name());
+  std::string prefix = s->object->get_name();
   s->object->set_key(rgw_obj_key());
 
   return new RGWWebsiteListing(std::move(prefix));