If we use a small osd_min[max]_pg_log_entries setting, say, 10, and
do splitting, a child pg may only be able to keep some divergent log
entries in the list. Any follow-up peering cycle on that child pg
would then rewind all the divergent log entries and lead to an empty
log list, which as a result could reliably fire the
ceph_assert(info.last_complete == info.last_update)
assert if we start to recover any of the missing divergent objects
later.
Fixes: https://tracker.ceph.com/issues/41816
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
(cherry picked from commit
a5e9e9099865be7a3d90c58cf3f3fc50ed6eed6d)
Conflicts:
src/osd/PeeringState.cc
- file does not exist in the stable branch: made the changes manually to
src/osd/PrimaryLogPG.cc
{
dout(10) << "got missing " << oid << " v " << v << dendl;
pg_log.recover_got(oid, v, info);
- if (pg_log.get_log().complete_to != pg_log.get_log().log.end()) {
+ if (pg_log.get_log().log.empty()) {
+ dout(10) << "last_complete now " << info.last_complete
+ << " while log is empty" << dendl;
+ } else if (pg_log.get_log().complete_to != pg_log.get_log().log.end()) {
dout(10) << "last_complete now " << info.last_complete
<< " log.complete_to " << pg_log.get_log().complete_to->version
<< dendl;