]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph-volume: batch mixed type scenarios have no need to calulate data size
authorAndrew Schoen <aschoen@redhat.com>
Tue, 4 Dec 2018 20:23:47 +0000 (14:23 -0600)
committerJan Fajerski <jfajerski@suse.com>
Fri, 19 Jul 2019 10:50:51 +0000 (12:50 +0200)
We know with a mixed type scenario the device used for data will be used
at 100% capacity. This means we do not need to be explict when asking
for the size of the data lvs, which avoids rounding errors with very
small device sizes.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 0023961397d19659200eaf420f2789db17a71b34)

src/ceph-volume/ceph_volume/devices/lvm/strategies/bluestore.py
src/ceph-volume/ceph_volume/devices/lvm/strategies/filestore.py

index e9a0e268c9b89929cb51230dbaffab7054c34326..d0630e768a7112f2dca196f3f995f3f6b073b736 100644 (file)
@@ -259,9 +259,8 @@ class MixedType(MixedStrategy):
         # block.db vg from before
         for osd in self.computed['osds']:
             data_path = osd['data']['path']
-            data_lv_size = disk.Size(b=osd['data']['size']).gb.as_int()
             data_vg = data_vgs[data_path]
-            data_lv_extents = data_vg.sizing(size=data_lv_size)['extents']
+            data_lv_extents = data_vg.sizing(parts=1)['extents']
             data_lv = lvm.create_lv(
                 'osd-block', data_vg.name, extents=data_lv_extents, uuid_name=True
             )
index 59a068f28e1b81852bd91d86d8189ff4dee7e078..a642893d4bef407c7443b9bc1f38783025e67c64 100644 (file)
@@ -338,9 +338,8 @@ class MixedType(MixedStrategy):
 
         for osd in self.computed['osds']:
             data_path = osd['data']['path']
-            data_lv_size = disk.Size(b=osd['data']['size']).gb.as_int()
             data_vg = data_vgs[data_path]
-            data_lv_extents = data_vg.sizing(size=data_lv_size)['extents']
+            data_lv_extents = data_vg.sizing(parts=1)['extents']
             data_lv = lvm.create_lv(
                 'osd-data', data_vg.name, extents=data_lv_extents, uuid_name=True
             )