Fix mds dump_ops_in_flight crashing ocassionally

diff --git a/src/mds/Mutation.cc b/src/mds/Mutation.cc
index 27eadf9d82e6414cdadf29ba2d0defb2ed6bf466..7dbc6e7ed6fd7ca7c9997ce6dde385fc4c790c31 100644 (file)
--- a/src/mds/Mutation.cc
+++ b/src/mds/Mutation.cc
@@ -329,7 +329,7 @@ void MDRequestImpl::_dump(utime_t now, Formatter *f) const
       f->dump_stream("client") << client_request->get_orig_source();
       f->dump_int("tid", client_request->get_tid());
       f->close_section(); // client_info
-    } else if (slave_request && !slave_request->is_reply()) { // replies go to an existing mdr
+    } else if (is_slave() && slave_request) { // replies go to an existing mdr
       f->dump_string("op_type", "slave_request");
       f->open_object_section("master_info");
       f->dump_stream("master") << slave_request->get_orig_source();

diff --git a/src/mds/Mutation.h b/src/mds/Mutation.h
index bc091c7b28800c87d713f16c98d6b9849d5548fe..f43d6609bacbdb8e6cb01c1dd412e6af895befb6 100644 (file)
--- a/src/mds/Mutation.h
+++ b/src/mds/Mutation.h
@@ -110,8 +110,8 @@ public:
     assert(remote_wrlocks.empty());
   }
 
-  bool is_master() { return slave_to_mds == MDS_RANK_NONE; }
-  bool is_slave() { return slave_to_mds != MDS_RANK_NONE; }
+  bool is_master() const { return slave_to_mds == MDS_RANK_NONE; }
+  bool is_slave() const { return slave_to_mds != MDS_RANK_NONE; }
 
   client_t get_client() {
     if (reqid.name.is_client())