]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mds-client: make the fake inos option unchangeable in runtime
authorXiubo Li <xiubli@redhat.com>
Wed, 23 Mar 2022 02:05:32 +0000 (10:05 +0800)
committerXiubo Li <xiubli@redhat.com>
Tue, 30 Aug 2022 02:38:18 +0000 (10:38 +0800)
If the flags is empty then in option.h in can_update_at_runtime()
it will return true. That means this opetion could be changed in
runtime, which is buggy. Because if this is false, ceph-fuse will
use its own fake inos instead of libcephfs'. If this is changed
during runtime, we will hit inos dosn't exist assert bugs.

Fixes: https://tracker.ceph.com/issues/54653
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 28d17ff81a93d5442d2107abbd51296ac822073a)

 Conflicts:
src/common/options/mds-client.yaml.in

src/common/options.cc

index ee7fe4830a78a37600cf54de44dc78d951c69879..dd4171af44eb370b07fe6d8c3db2002c2028f688 100644 (file)
@@ -9168,6 +9168,8 @@ std::vector<Option> get_mds_client_options() {
     .set_description("confirm access to inode's data pool/namespace described in file layout"),
 
     Option("client_use_faked_inos", Option::TYPE_BOOL, Option::LEVEL_DEV)
+    .set_flag(Option::FLAG_STARTUP)
+    .set_flag(Option::FLAG_NO_MON_UPDATE)
     .set_default(false)
     .set_description(""),