]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mds/Server.cc: fix possible NULL pointer dereference
authorDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Tue, 14 May 2013 17:07:29 +0000 (19:07 +0200)
committerDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Tue, 14 May 2013 17:07:29 +0000 (19:07 +0200)
Assert of straydn is NULL here.

CID 1019558 (#1 of 1): Dereference after null check (FORWARD_NULL)
  var_deref_model: Passing null pointer "straydn" to function
  "CDentry::get_dir() const", which dereferences it.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
src/mds/Server.cc

index 3e89156cd93d52d7d540361cfa4b03a2d7e088f2..46adf2200213cbc17beb09d04cde3ba1ef7cdf69 100644 (file)
@@ -7100,6 +7100,7 @@ void Server::_rename_rollback_finish(Mutation *mut, MDRequest *mdr, CDentry *src
   if (destdn) {
     CInode *oldin = destdn->get_linkage()->get_inode();
     // update subtree map?
+    assert(straydn);
     if (oldin && oldin->is_dir())
       mdcache->adjust_subtree_after_rename(oldin, straydn->get_dir(), true);
   }