mon/MDSMonitor: Add confirmation to "ceph mds setmap"

Signed-off-by: Yan, Zheng <zyan@redhat.com>

diff --git a/src/mon/MDSMonitor.cc b/src/mon/MDSMonitor.cc
index c0fad8e074897fce8a32c70a5fa23e19051d494f..df27922f439cb99da062054fb749bad79367318b 100644 (file)
--- a/src/mon/MDSMonitor.cc
+++ b/src/mon/MDSMonitor.cc
@@ -1567,6 +1567,14 @@ int MDSMonitor::filesystem_command(
     }
     r = 0;
   } else if (prefix == "mds setmap") {
+    string confirm;
+    if (!cmd_getval(g_ceph_context, cmdmap, "confirm", confirm) ||
+       confirm != "--yes-i-really-mean-it") {
+      ss << "WARNING: this can make your filesystem inaccessible! "
+           "Add --yes-i-really-mean-it if you are sure you wish to continue.";
+      return -EINVAL;;
+    }
+
     MDSMap map;
     try {
       map.decode(m->get_data());

diff --git a/src/mon/MonCommands.h b/src/mon/MonCommands.h
index 8d09f91fba040b1501270520cb89e04dfc53ac63..a85758a209eab3f49e27f99b9beb786b280d133d 100644 (file)
--- a/src/mon/MonCommands.h
+++ b/src/mon/MonCommands.h
@@ -326,7 +326,8 @@ COMMAND("mds set " \
        "name=confirm,type=CephString,req=false",                       \
        "set mds parameter <var> to <val>", "mds", "rw", "cli,rest")
 COMMAND("mds setmap " \
-       "name=epoch,type=CephInt,range=0", \
+       "name=epoch,type=CephInt,range=0 " \
+       "name=confirm,type=CephString,req=false",
        "set mds map; must supply correct epoch number", "mds", "rw", "cli,rest")
 // arbitrary limit 0-20 below; worth standing on head to make it
 // relate to actual state definitions?