MOSDOp: drop ops vector in clear_data()

Otherwise, clear_data on MOSDOp will leave essentially
all of the buffers intact.  This is a problem since the
OpTracker mechanism relies on being able to keep the mesage
around without keeping around the data.

Signed-off-by: Samuel Just <sam.just@inktank.com>

diff --git a/src/messages/MOSDOp.h b/src/messages/MOSDOp.h
index 32408bebeedb775438a988a950152bc427a37de8..5c70d8bbc47c9f1e2eaf9fb97fe18daff3b3488d 100644 (file)
--- a/src/messages/MOSDOp.h
+++ b/src/messages/MOSDOp.h
@@ -337,6 +337,9 @@ struct ceph_osd_request_head {
     OSDOp::split_osd_op_vector_in_data(ops, data);
   }
 
+  void clear_buffers() {
+    ops.clear();
+  }
 
   const char *get_type_name() const { return "osd_op"; }
   void print(ostream& out) const {

diff --git a/src/msg/Message.h b/src/msg/Message.h
index fbca242e2052a54ba3974a180387b541a03a6bbd..740be7be716c3a39b1034460ea6df43028d6578e 100644 (file)
--- a/src/msg/Message.h
+++ b/src/msg/Message.h
@@ -403,10 +403,13 @@ public:
     payload.clear();
     middle.clear();
   }
+
+  virtual void clear_buffers() {}
   void clear_data() {
     if (byte_throttler)
       byte_throttler->put(data.length());
     data.clear();
+    clear_buffers(); // let subclass drop buffers as well
   }
 
   bool empty_payload() { return payload.length() == 0; }