common/options: convert `long_desc` to C string

All parameters are C strings (either C literals, except for
MgrMonitor::update_from_paxos()) and there's no point in copying all
of them onto the heap during startup.

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

diff --git a/src/common/options.cc b/src/common/options.cc
index bbac26e261cd82fda562b3192f0ff3bbcc2eb3a1..d57dc4b9fb7428059f1fff9446099b6240fd0630 100644 (file)
--- a/src/common/options.cc
+++ b/src/common/options.cc
@@ -333,7 +333,7 @@ void Option::print(ostream *out) const
     *out << "  See also: " << see_also << "\n";
   }
 
-  if (long_desc.size()) {
+  if (*long_desc != '\0') {
     *out << "\n" << long_desc << "\n";
   }
 }

diff --git a/src/common/options.h b/src/common/options.h
index f99433464bcdbc7541a19c8e87bb76ea90ea5445..e387e9d1c3a1704439d4fd9c2f0ea2d5b3009737 100644 (file)
--- a/src/common/options.h
+++ b/src/common/options.h
@@ -167,7 +167,7 @@ struct Option {
   const level_t level;
 
   std::string desc;
-  std::string long_desc;
+  const char *long_desc = "";
 
   unsigned flags = 0;