]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
pybind/ceph_argparse: fix no arg check 15500/head
authorSage Weil <sage@redhat.com>
Tue, 6 Jun 2017 13:23:32 +0000 (09:23 -0400)
committerSage Weil <sage@redhat.com>
Tue, 6 Jun 2017 13:23:32 +0000 (09:23 -0400)
This fixes breakage from commit a1214a702cfd8465deb91847f4dc63c0e80fb586
that caused a [] to be appended to some json argument lists.

Fixes: http://tracker.ceph.com/issues/20135
Signed-off-by: Sage Weil <sage@redhat.com>
src/pybind/ceph_argparse.py

index 54fbdeb49f2e2971a5777a4627efc8ee2ae41c1b..cc96d7708dc95668453e0d3374a333ca751f9b8f 100644 (file)
@@ -924,12 +924,12 @@ def validate(args, signature, flags=0, partial=False):
 
             # no arg, but not required?  Continue consuming mysig
             # in case there are later required args
-            if myarg == None and not desc.req:
+            if myarg in (None, []) and not desc.req:
                 break
 
             # out of arguments for a required param?
             # Either return (if partial validation) or raise
-            if myarg == None and desc.req:
+            if myarg in (None, []) and desc.req:
                 if desc.N and desc.numseen < 1:
                     # wanted N, didn't even get 1
                     if partial: