]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
rgw: clean code with helper function dump_header_if_nonempty 18979/head
authorXinying Song <songxinying@cloudin.cn>
Fri, 17 Nov 2017 06:18:07 +0000 (14:18 +0800)
committerXinying Song <songxinying@cloudin.cn>
Fri, 17 Nov 2017 06:18:07 +0000 (14:18 +0800)
Signed-off-by: Xinying Song <songxinying@cloudin.cn>
src/rgw/rgw_rest_s3.cc

index bdd8ea4ee8593fee5ffc65c034496e86dc6c5ce1..840a63d34626729e255acee981904ae95a0a7ee7 100644 (file)
@@ -245,10 +245,7 @@ int RGWGetObj_ObjStore_S3::send_response_data(bufferlist& bl, off_t bl_ofs,
 
   dump_content_length(s, total_len);
   dump_last_modified(s, lastmod);
-  if (!version_id.empty()) {
-    dump_header(s, "x-amz-version-id", version_id);
-  }
-  
+  dump_header_if_nonempty(s, "x-amz-version-id", version_id);
 
   if (! op_ret) {
     if (! lo_etag.empty()) {
@@ -2042,9 +2039,7 @@ void RGWDeleteObj_ObjStore_S3::send_response()
 
   set_req_state_err(s, r);
   dump_errno(s);
-  if (!version_id.empty()) {
-    dump_header(s, "x-amz-version-id", version_id);
-  }
+  dump_header_if_nonempty(s, "x-amz-version-id", version_id);
   if (delete_marker) {
     dump_header(s, "x-amz-delete-marker", "true");
   }