]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
client: fix error operator precedence 21495/head
authorPatrick Donnelly <pdonnell@redhat.com>
Tue, 17 Apr 2018 13:39:09 +0000 (06:39 -0700)
committerPrashant D <pdhange@redhat.com>
Thu, 31 May 2018 09:38:51 +0000 (05:38 -0400)
    /home/pdonnell/ceph/src/client/Client.cc: In member function ‘int Client::mount(const string&, const UserPerm&, bool)’:
    /home/pdonnell/ceph/src/client/Client.cc:5681:23: warning: suggest parentheses around ‘+’ inside ‘<<’ [-Wparentheses]
        return CEPH_FUSE_NO_MDS_UP;
                    ~~^~

Found by gcc. I am ashamed.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 75f980d85256e22b7b79e5f64bfa3fc6018328b5)

src/client/Client.h

index d5f40b18b22ff83f0b88ab8928149279f239639b..75728189878ed70cf8bceab8a8248f6e27e7b130 100644 (file)
@@ -94,8 +94,8 @@ class MDSCommandOp : public CommandOp
 };
 
 /* error code for ceph_fuse */
-#define CEPH_FUSE_NO_MDS_UP    -(1<<16+0) /* no mds up deteced in ceph_fuse */
-#define CEPH_FUSE_LAST         -(1<<16+1) /* (unused) */
+#define CEPH_FUSE_NO_MDS_UP    -((1<<16)+0) /* no mds up deteced in ceph_fuse */
+#define CEPH_FUSE_LAST         -((1<<16)+1) /* (unused) */
 
 // ============================================
 // types for my local metadata cache