osd/Session: fix invalid iterator dereference in Sessoin::have_backoff()

If p is i->second.end(), we do want to back up a position, but we
shouldn't dereference p for p->first.

Fixes: http://tracker.ceph.com/issues/24486
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 2d7bfafa879ca1475173a74a84c66fd7f5e1b6bc)

diff --git a/src/osd/Session.h b/src/osd/Session.h
index 3ef40f4102ae0854e18a90ed3a23a108b4112358..76b892c9dabcb6d59205e8e9cc23b11e5862a2b5 100644 (file)
--- a/src/osd/Session.h
+++ b/src/osd/Session.h
@@ -177,7 +177,7 @@ struct Session : public RefCountedObject {
     }
     auto p = i->second.lower_bound(oid);
     if (p != i->second.begin() &&
-       p->first > oid) {
+       (p == i->second.end() || p->first > oid)) {
       --p;
     }
     if (p != i->second.end()) {