]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
osd/PG: calc_min_last_complete_ondisk should return nothing 23587/head
authorxie xingguo <xie.xingguo@zte.com.cn>
Tue, 14 Aug 2018 06:57:03 +0000 (14:57 +0800)
committerxie xingguo <xie.xingguo@zte.com.cn>
Fri, 17 Aug 2018 00:23:53 +0000 (08:23 +0800)
As we now no more use it to calc pg_trim_to.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
src/osd/PG.h

index bfc22e8d50dfcc37242a45a77bc3fd840bee72b8..bd2d196e68eff3cbfaa1ec43a00ca5f29baea18c 100644 (file)
@@ -1354,7 +1354,7 @@ protected:
   bool all_unfound_are_queried_or_lost(const OSDMapRef osdmap) const;
   virtual void dump_recovery_info(Formatter *f) const = 0;
 
-  bool calc_min_last_complete_ondisk() {
+  void calc_min_last_complete_ondisk() {
     eversion_t min = last_complete_ondisk;
     assert(!acting_recovery_backfill.empty());
     for (set<pg_shard_t>::iterator i = acting_recovery_backfill.begin();
@@ -1362,15 +1362,15 @@ protected:
         ++i) {
       if (*i == get_primary()) continue;
       if (peer_last_complete_ondisk.count(*i) == 0)
-       return false;   // we don't have complete info
+       return;   // we don't have complete info
       eversion_t a = peer_last_complete_ondisk[*i];
       if (a < min)
        min = a;
     }
     if (min == min_last_complete_ondisk)
-      return false;
+      return;
     min_last_complete_ondisk = min;
-    return true;
+    return;
   }
 
   virtual void calc_trim_to() = 0;