mgr/cephadm: fix =[] default arg to _create_daemon

This is a no-no (pass by reference, not value)!

Signed-off-by: Sage Weil <sage@redhat.com>

diff --git a/src/pybind/mgr/cephadm/module.py b/src/pybind/mgr/cephadm/module.py
index 89e04bc2ec6ce61c89541a3b21259cd79418a5e8..384fba9e767c513474f1067043de7be703e614a5 100644 (file)
--- a/src/pybind/mgr/cephadm/module.py
+++ b/src/pybind/mgr/cephadm/module.py
@@ -1044,8 +1044,10 @@ class CephadmOrchestrator(MgrModule, orchestrator.Orchestrator):
         return self._remove_daemon(args)
 
     def _create_daemon(self, daemon_type, daemon_id, host, keyring,
-                       extra_args=[], extra_config=None,
+                       extra_args=None, extra_config=None,
                        reconfig=False):
+        if not extra_args:
+            extra_args = []
         name = '%s.%s' % (daemon_type, daemon_id)
 
         # generate config