]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/os: mark class with "final" dtor "final" 37565/head
authorKefu Chai <kchai@redhat.com>
Tue, 6 Oct 2020 11:09:18 +0000 (19:09 +0800)
committerKefu Chai <kchai@redhat.com>
Tue, 6 Oct 2020 14:22:25 +0000 (22:22 +0800)
to silence warning like

scheduler.cc:145:30: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
  ~ClassedOpQueueScheduler() final {};
                             ^
/home/jenkins-build/build/workspace/ceph-perf-crimson/ceph-pr/src/crimson/osd/scheduler/scheduler.cc:52:7: note: mark 'ClassedOpQueueScheduler<T>' as 'final' to silence this warning
class ClassedOpQueueScheduler : public Scheduler {
      ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/crimson/osd/scheduler/scheduler.cc

index 93ffa40a919ae735bcd32d4386c19297f77648ca..c85cb388ef36e255407cd447e096fc433e0f97ba 100644 (file)
@@ -49,7 +49,7 @@ std::ostream &operator<<(std::ostream &lhs, const scheduler_class_t &c)
  * OpQueue based implementations.
  */
 template <typename T>
-class ClassedOpQueueScheduler : public Scheduler {
+class ClassedOpQueueScheduler final : public Scheduler {
   const scheduler_class_t cutoff;
   T queue;