]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
src/*: drop backward compatibility with boost<1.72 38263/head
authorKefu Chai <kchai@redhat.com>
Tue, 24 Nov 2020 06:36:30 +0000 (14:36 +0800)
committerKefu Chai <kchai@redhat.com>
Tue, 24 Nov 2020 07:50:19 +0000 (15:50 +0800)
boost 1.72 is required to build Ceph since
713efb66e8d7b2585dfd6783f8f23ce409b50871. so there is no need to be
backward compatible with older Boost libraries.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/json_spirit/json_spirit_reader_template.h
src/rgw/rgw_dmclock_async_scheduler.h
src/rgw/rgw_reshard.h
src/test/confutils.cc

index 7d394b26e7d3d838291d7e0332a10864d2b81857..a5790b9b5e1df916e148d34bcc2a5ca878bb8e8c 100644 (file)
 #include <boost/bind/bind.hpp>\r
 #include <boost/function.hpp>\r
 #include <boost/version.hpp>\r
-\r
-#if BOOST_VERSION >= 103800\r
-    #include <boost/spirit/include/classic_core.hpp>\r
-    #include <boost/spirit/include/classic_confix.hpp>\r
-    #include <boost/spirit/include/classic_escape_char.hpp>\r
-    #include <boost/spirit/include/classic_multi_pass.hpp>\r
-    #include <boost/spirit/include/classic_position_iterator.hpp>\r
-    #define spirit_namespace boost::spirit::classic\r
-#else\r
-    #include <boost/spirit/core.hpp>\r
-    #include <boost/spirit/utility/confix.hpp>\r
-    #include <boost/spirit/utility/escape_char.hpp>\r
-    #include <boost/spirit/iterator/multi_pass.hpp>\r
-    #include <boost/spirit/iterator/position_iterator.hpp>\r
-    #define spirit_namespace boost::spirit\r
-#endif\r
+#include <boost/spirit/include/classic_core.hpp>\r
+#include <boost/spirit/include/classic_confix.hpp>\r
+#include <boost/spirit/include/classic_escape_char.hpp>\r
+#include <boost/spirit/include/classic_multi_pass.hpp>\r
+#include <boost/spirit/include/classic_position_iterator.hpp>\r
 \r
 #include "include/ceph_assert.h"\r
 \r
 namespace json_spirit\r
 {\r
+    namespace spirit_namespace = boost::spirit::classic;\r
+\r
     const spirit_namespace::int_parser < boost::int64_t >  int64_p  = spirit_namespace::int_parser < boost::int64_t  >();\r
     const spirit_namespace::uint_parser< boost::uint64_t > uint64_p = spirit_namespace::uint_parser< boost::uint64_t >();\r
 \r
index 20c04a666796f39b420a2f94f2fd8085f8774eb2..2a4c99f20a8413ddc455be67e75d8271e69f0cd1 100644 (file)
@@ -82,12 +82,8 @@ class AsyncScheduler : public md_config_obs_t, public Scheduler {
   using Completion = async::Completion<Signature, async::AsBase<Request>>;
 
   using Clock = ceph::coarse_real_clock;
-#if BOOST_VERSION < 107000
-  using Timer = boost::asio::basic_waitable_timer<Clock>;
-#else
   using Timer = boost::asio::basic_waitable_timer<Clock,
         boost::asio::wait_traits<Clock>, executor_type>;
-#endif
   Timer timer; //< timer for the next scheduled request
 
   CephContext *const cct;
index 4bfbf5f810a68c302b080b308611d1821ee317e9..a5c190f59143fd110be5f89395b25ad52f84ff8a 100644 (file)
@@ -253,13 +253,9 @@ class RGWReshardWait {
   ceph::condition_variable cond;
 
   struct Waiter : boost::intrusive::list_base_hook<> {
-#if BOOST_VERSION < 107000
-    using Timer = boost::asio::basic_waitable_timer<Clock>;
-#else
     using Executor = boost::asio::io_context::executor_type;
     using Timer = boost::asio::basic_waitable_timer<Clock,
           boost::asio::wait_traits<Clock>, Executor>;
-#endif
     Timer timer;
     explicit Waiter(boost::asio::io_context& ioc) : timer(ioc) {}
   };
index 831e913351f21e39dc5b2f2e1913aacd69b8ce50..88e5bf450ac40fa48f7c2cc91b0891889ad02c54 100644 (file)
@@ -231,17 +231,6 @@ const char illegal_conf4[] = "\
         keyring = osd_keyring          ; osd's keyring\n\
 ";
 
-#if BOOST_VERSION < 107200
-// Boost::spirit > 1.72 asserts on chars that are not < 0x7f
-// unicode config file
-const char unicode_config_1[] = "\
-[global]\n\
-        log file =           \x66\xd1\x86\xd1\x9d\xd3\xad\xd3\xae     \n\
-        pid file =           foo-bar\n\
-[osd0]\n\
-";
-#endif
-
 const char override_config_1[] = "\
 [global]\n\
         log file =           global_log\n\
@@ -365,15 +354,6 @@ TEST(ConfUtils, ReadFiles2) {
   ASSERT_EQ(val, "/quite/a/long/path/for/a/log/file");
   ASSERT_EQ(cf1.read("global", "pid file", val), 0);
   ASSERT_EQ(val, "spork");
-
-#if BOOST_VERSION < 107200
-  std::string unicode_config_1f(next_tempfile(unicode_config_1));
-  ConfFile cf2;
-  ASSERT_EQ(cf2.parse_file(unicode_config_1f.c_str(), &err), 0);
-  ASSERT_EQ(err.tellp(), 0U);
-  ASSERT_EQ(cf2.read("global", "log file", val), 0);
-  ASSERT_EQ(val, "\x66\xd1\x86\xd1\x9d\xd3\xad\xd3\xae");
-#endif
 }
 
 TEST(ConfUtils, IllegalFiles) {