]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
fix a few minor compilation warnings 4007/head
authorLoic Dachary <ldachary@redhat.com>
Sun, 15 Mar 2015 23:14:00 +0000 (00:14 +0100)
committerLoic Dachary <ldachary@redhat.com>
Mon, 16 Mar 2015 07:13:44 +0000 (08:13 +0100)
Signed-off-by: Loic Dachary <ldachary@redhat.com>
src/rbd_fuse/rbd-fuse.cc
src/rgw/rgw_common.h
src/rgw/rgw_rados.cc
src/test/librbd/test_librbd.cc

index c53e5b6c3dfac974e89a2749639c10fb0c0e8159..58d3e2a5e187103f106adf80742a46f62773e4d1 100644 (file)
@@ -349,7 +349,7 @@ static int rbdfs_write(const char *path, const char *buf, size_t size,
        while (size > 0) {
                ssize_t ret;
 
-               if (offset + size > rbdsize(fi->fh)) {
+               if ((size_t)(offset + size) > rbdsize(fi->fh)) {
                        int r;
                        fprintf(stderr, "rbdfs_write resizing %s to 0x%"PRIxMAX"\n",
                                path, offset+size);
index 75f72281dadbb64e859aca0e6df5e0305634e159..0a796c08deaf4bcba2e4d574b650e4fc0cd74163 100644 (file)
@@ -149,7 +149,7 @@ using ceph::crypto::MD5;
 #define ERR_INTERNAL_ERROR       2200
 
 #ifndef UINT32_MAX
-#define UINT32_MAX (4294967295)
+#define UINT32_MAX (0xffffffffu)
 #endif
 
 typedef void *RGWAccessHandle;
index 2f7c7af1b30ba46e4bef0ef518ea2e35ac1369d3..b5efc81fba8ea7a5dafbec6b4a3c37dcdbac0039 100644 (file)
@@ -6603,9 +6603,9 @@ int RGWRados::get_bucket_stats(rgw_bucket& bucket, string *bucket_ver, string *m
   char buf[64];
   for(; iter != headers.end(); ++iter, ++viter) {
     accumulate_raw_stats(iter->second, stats);
-    snprintf(buf, sizeof(buf), "%lu", iter->second.ver);
+    snprintf(buf, sizeof(buf), "%lu", (unsigned long)iter->second.ver);
     ver_mgr.add(viter->first, string(buf));
-    snprintf(buf, sizeof(buf), "%lu", iter->second.master_ver);
+    snprintf(buf, sizeof(buf), "%lu", (unsigned long)iter->second.master_ver);
     master_ver_mgr.add(viter->first, string(buf));
     marker_mgr.add(viter->first, iter->second.max_marker);
   }
index cf76c67c7b645c4914014adb1631cc86ba556d72..68b634bfa44ea43906ebd47b9887d5c2a9139ba1 100644 (file)
@@ -1450,8 +1450,8 @@ TEST_F(TestLibRBD, TestCoR)
   // make a parent to clone from
   ASSERT_EQ(0, create_image_full(ioctx, "parent", image_size, &order, false, features));
   ASSERT_EQ(0, rbd_open(ioctx, "parent", &parent, NULL));
-  printf("made parent image \"parent\": %ldK (%d * %dK)\n", 
-         image_size, object_num, object_size/1024);
+  printf("made parent image \"parent\": %ldK (%d * %dK)\n",
+         (unsigned long)image_size, object_num, object_size/1024);
 
   // write something into parent
   char test_data[TEST_IO_SIZE + 1];
@@ -1477,18 +1477,19 @@ TEST_F(TestLibRBD, TestCoR)
   printf("generated random write map:\n");
   for (map<uint64_t, uint64_t>::iterator itr = write_tracker.begin();
        itr != write_tracker.end(); ++itr)
-    printf("\t [%-8ld, %-8ld]\n", itr->first, itr->second);
+    printf("\t [%-8ld, %-8ld]\n",
+          (unsigned long)itr->first, (unsigned long)itr->second);
 
   printf("write data based on random map\n");
   for (map<uint64_t, uint64_t>::iterator itr = write_tracker.begin();
        itr != write_tracker.end(); ++itr) {
-    printf("\twrite object-%-4ld\t", itr->first);
+    printf("\twrite object-%-4ld\t", (unsigned long)itr->first);
     ASSERT_PASSED(write_test_data, parent, test_data, itr->first * object_size + itr->second, TEST_IO_SIZE, 0);
   }
 
   for (map<uint64_t, uint64_t>::iterator itr = write_tracker.begin();
          itr != write_tracker.end(); ++itr) {
-    printf("\tread object-%-4ld\t", itr->first);
+    printf("\tread object-%-4ld\t", (unsigned long)itr->first);
     ASSERT_PASSED(read_test_data, parent, test_data, itr->first * object_size + itr->second, TEST_IO_SIZE, 0);
   }
 
@@ -1522,20 +1523,20 @@ TEST_F(TestLibRBD, TestCoR)
   printf("read from \"child\"\n");
   {
     map<uint64_t, uint64_t>::iterator itr = write_tracker.begin();
-    printf("\tread object-%-4ld\t", itr->first);
+    printf("\tread object-%-4ld\t", (unsigned long)itr->first);
     ASSERT_PASSED(read_test_data, child, test_data, itr->first * object_size + itr->second, TEST_IO_SIZE, 0);
   }
 
   for (map<uint64_t, uint64_t>::iterator itr = write_tracker.begin();
        itr != write_tracker.end(); ++itr) {
-    printf("\tread object-%-4ld\t", itr->first);
+    printf("\tread object-%-4ld\t", (unsigned long)itr->first);
     ASSERT_PASSED(read_test_data, child, test_data, itr->first * object_size + itr->second, TEST_IO_SIZE, 0);
   }
 
   printf("read again reversely\n");
   for (map<uint64_t, uint64_t>::iterator itr = --write_tracker.end();
      itr != write_tracker.begin(); --itr) {
-    printf("\tread object-%-4ld\t", itr->first);
+    printf("\tread object-%-4ld\t", (unsigned long)itr->first);
     ASSERT_PASSED(read_test_data, child, test_data, itr->first * object_size + itr->second, TEST_IO_SIZE, 0);
   }