]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/dashboard:OSDs placement text is unreadable 41083/head
authorAashish Sharma <aashishsharma@localhost.localdomain>
Thu, 29 Apr 2021 12:57:59 +0000 (18:27 +0530)
committerAashish Sharma <aashishsharma@localhost.localdomain>
Thu, 29 Apr 2021 13:56:17 +0000 (19:26 +0530)
While displaying the host pattern in the OSDs placement tab, it gets splited with semi-colons. Also adjusted the column size of Container Image ID and Placement columns.

Fixes: https://tracker.ceph.com/issues/50580
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/placement.pipe.spec.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/placement.pipe.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/services.component.ts

index 6aef3c364cbe60a521e816ceb6ace403eb989e70..588744aa6f04c5f947ca39b8cc3dbdb68c838eab 100644 (file)
@@ -59,10 +59,10 @@ describe('PlacementPipe', () => {
     expect(
       pipe.transform({
         placement: {
-          host_pattern: '*'
+          host_pattern: 'abc.ceph.xyz.com'
         }
       })
-    ).toBe('*');
+    ).toBe('abc.ceph.xyz.com');
   });
 
   it('transforms placement (6)', () => {
index bd461bceb2f9fc5345ddf434793d91386e31b577..5aee65890a2f192e0e62dd48243b597ef1bf82d1 100644 (file)
@@ -34,7 +34,7 @@ export class PlacementPipe implements PipeTransform {
       kv.push($localize`label:${label}`);
     }
     if (_.isString(hostPattern)) {
-      kv.push(...hostPattern);
+      kv.push(hostPattern);
     }
     return kv.join(';');
   }
index 32d27bc1f4fd804da04b1e59d054a27b80a39579..75ddd1c46175350c164f8264628daf3379b688cf 100644 (file)
@@ -104,7 +104,7 @@ export class ServicesComponent extends ListWithDetails implements OnChanges, OnI
       {
         name: $localize`Container image ID`,
         prop: 'status.container_image_id',
-        flexGrow: 3,
+        flexGrow: 1.5,
         cellTransformation: CellTemplate.truncate,
         customTemplateConfig: {
           length: 12
@@ -114,7 +114,7 @@ export class ServicesComponent extends ListWithDetails implements OnChanges, OnI
         name: $localize`Placement`,
         prop: '',
         pipe: new PlacementPipe(),
-        flexGrow: 1
+        flexGrow: 2
       },
       {
         name: $localize`Running`,